Make sure to null terminate argument lists!

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@20166 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/tools/gccld/GenerateCode.cpp b/tools/gccld/GenerateCode.cpp
index b189d0654f58101ec3216f41f4ebc64590535b50..1d4c5205cffb676b1fe7ddefa6db19037b542fa8 100644 (file)
--- a/tools/gccld/GenerateCode.cpp
+++ b/tools/gccld/GenerateCode.cpp
@@ -247,6 +247,7 @@ int llvm::GenerateAssembly(const std::string &OutputFilename,
   args.push_back("-o");
   args.push_back(OutputFilename.c_str());
   args.push_back(InputFilename.c_str());
+  args.push_back(0);
 
   return sys::Program::ExecuteAndWait(llc, &args[0]);
 }
@@ -263,6 +264,7 @@ int llvm::GenerateCFile(const std::string &OutputFile,
   args.push_back("-o");
   args.push_back(OutputFile.c_str());
   args.push_back(InputFile.c_str());
+  args.push_back(0);
   return sys::Program::ExecuteAndWait(llc, &args[0]);
 }
 
@@ -322,6 +324,7 @@ int llvm::GenerateNative(const std::string &OutputFilename,
       args.push_back(Libraries[index].c_str());
     }
   }
+  args.push_back(0);
 
   // Run the compiler to assembly and link together the program.
   return sys::Program::ExecuteAndWait(gcc, &args[0], (const char**)clean_env);

diff --git a/tools/gccld/gccld.cpp b/tools/gccld/gccld.cpp
index 809db2adacc4d0492b76f31712436425819cc532..00cf6571927f8c6fce12bb5bbb03ecd4d1451672 100644 (file)
--- a/tools/gccld/gccld.cpp
+++ b/tools/gccld/gccld.cpp
@@ -299,7 +299,7 @@ int main(int argc, char **argv, char **envp ) {
                        Libraries, gcc, envp );
 
         // Remove the assembly language file.
-        AssemblyFile.destroyFile();;
+        AssemblyFile.destroyFile();
       } else if (NativeCBE) {
         sys::Path CFile (OutputFilename);
         CFile.appendSuffix("cbe.c");