mm: remove unused arg of set_page_dirty_balance()
authorMiklos Szeredi <mszeredi@suse.cz>
Mon, 7 Apr 2014 22:37:51 +0000 (15:37 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Mon, 7 Apr 2014 23:35:57 +0000 (16:35 -0700)
There's only one caller of set_page_dirty_balance() and that will call it
with page_mkwrite == 0.

The page_mkwrite argument was unused since commit b827e496c893 "mm: close
page_mkwrite races".

Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
include/linux/writeback.h
mm/memory.c
mm/page-writeback.c

index 021b8a319b9e2cf7f0f60a5f6fedcfe3367f8016..5777c13849ba828aefe843b560beb5511d823fa1 100644 (file)
@@ -178,7 +178,7 @@ int write_cache_pages(struct address_space *mapping,
                      struct writeback_control *wbc, writepage_t writepage,
                      void *data);
 int do_writepages(struct address_space *mapping, struct writeback_control *wbc);
-void set_page_dirty_balance(struct page *page, int page_mkwrite);
+void set_page_dirty_balance(struct page *page);
 void writeback_set_ratelimit(void);
 void tag_pages_for_writeback(struct address_space *mapping,
                             pgoff_t start, pgoff_t end);
index 854e4027719f123a2738c6db914fb7dc0a610440..d0f0bef3be488af9eb9406cc5d28272093abb5a6 100644 (file)
@@ -2782,7 +2782,7 @@ reuse:
                 */
                if (!page_mkwrite) {
                        wait_on_page_locked(dirty_page);
-                       set_page_dirty_balance(dirty_page, page_mkwrite);
+                       set_page_dirty_balance(dirty_page);
                        /* file_update_time outside page_lock */
                        if (vma->vm_file)
                                file_update_time(vma->vm_file);
index 7106cb1aca8e3733059b344a773310aa4bf0fcd7..ef413492a14945c5e7ab0f5a8d33bd66eaf34873 100644 (file)
@@ -1562,9 +1562,9 @@ pause:
                bdi_start_background_writeback(bdi);
 }
 
-void set_page_dirty_balance(struct page *page, int page_mkwrite)
+void set_page_dirty_balance(struct page *page)
 {
-       if (set_page_dirty(page) || page_mkwrite) {
+       if (set_page_dirty(page)) {
                struct address_space *mapping = page_mapping(page);
 
                if (mapping)