staging: comedi: pcl724: checkpatch.pl cleanup (else after return)
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Wed, 16 Jul 2014 17:43:24 +0000 (10:43 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 16 Jul 2014 20:34:22 +0000 (13:34 -0700)
Fix the checkpatch.pl warning:

WARNING: else is not generally useful after a break or return

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/pcl724.c

index 655bac42f6f0c6443dc4b372cc815c99ccff8561..c7f8eb1cf8de922ad20ec3fed7cda237cc170d86 100644 (file)
@@ -88,14 +88,12 @@ static int pcl724_8255mapped_io(int dir, int port, int data,
 
        iobase &= 0x0fff;
 
+       outb(port + movport, iobase);
        if (dir) {
-               outb(port + movport, iobase);
                outb(data, iobase + 1);
                return 0;
-       } else {
-               outb(port + movport, iobase);
-               return inb(iobase + 1);
        }
+       return inb(iobase + 1);
 }
 
 static int pcl724_attach(struct comedi_device *dev,