thinkpad_acpi: Remove side effects from vdbg_printk -> no_printk macro
authorJoe Perches <joe@perches.com>
Wed, 26 Aug 2015 18:13:38 +0000 (11:13 -0700)
committerDarren Hart <dvhart@linux.intel.com>
Fri, 28 Aug 2015 17:49:52 +0000 (10:49 -0700)
vdbg_printk when not using CONFIG_THINKPAD_ACPI_DEBUG uses
no_printk which produces no logging output but always
evaluates arguments.

Change the macro to surround the no_printk call with
do { if (0) no_printk(...); } while (0)
to avoid the unnecessary argument evaluations.

$ size drivers/platform/x86/thinkpad_acpi.o*
   text    data     bss     dec     hex filename
  60918    6184     824   67926   10956 drivers/platform/x86/thinkpad_acpi.o.new
  60927    6184     824   67935   1095f drivers/platform/x86/thinkpad_acpi.o.old

Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
drivers/platform/x86/thinkpad_acpi.c

index 33e488cf5569861391fc40844bcc6ce95b305c3c..131dd74641833e69e144f6a22d1d4021d09ee1c9 100644 (file)
@@ -402,7 +402,7 @@ static const char *str_supported(int is_supported);
 #else
 static inline const char *str_supported(int is_supported) { return ""; }
 #define vdbg_printk(a_dbg_level, format, arg...)       \
-       no_printk(format, ##arg)
+       do { if (0) no_printk(format, ##arg); } while (0)
 #endif
 
 static void tpacpi_log_usertask(const char * const what)