Support: Fix tests for VirtualityString
authorDuncan P. N. Exon Smith <dexonsmith@apple.com>
Sat, 7 Feb 2015 01:07:30 +0000 (01:07 +0000)
committerDuncan P. N. Exon Smith <dexonsmith@apple.com>
Sat, 7 Feb 2015 01:07:30 +0000 (01:07 +0000)
Since these `dwarf` functions return `const char *`, the tests need to
use `StringRef` for checks.  Should fix, e.g., hexagon [1].

[1]: http://lab.llvm.org:8011/builders/clang-hexagon-elf/builds/22435

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@228478 91177308-0d34-0410-b5e6-96231b3b80d8

unittests/Support/DwarfTest.cpp

index dfdf5a26a09db85a3fd212885b80382de6e8a3c8..5352982aa131949c1b8fdc0b9cb4805d1cbcd0fc 100644 (file)
@@ -96,13 +96,16 @@ TEST(DwarfTest, getAttributeEncoding) {
 }
 
 TEST(DwarfTest, VirtualityString) {
-  EXPECT_EQ("DW_VIRTUALITY_none", VirtualityString(DW_VIRTUALITY_none));
-  EXPECT_EQ("DW_VIRTUALITY_virtual", VirtualityString(DW_VIRTUALITY_virtual));
-  EXPECT_EQ("DW_VIRTUALITY_pure_virtual",
+  EXPECT_EQ(StringRef("DW_VIRTUALITY_none"),
+            VirtualityString(DW_VIRTUALITY_none));
+  EXPECT_EQ(StringRef("DW_VIRTUALITY_virtual"),
+            VirtualityString(DW_VIRTUALITY_virtual));
+  EXPECT_EQ(StringRef("DW_VIRTUALITY_pure_virtual"),
             VirtualityString(DW_VIRTUALITY_pure_virtual));
 
   // DW_VIRTUALITY_max should be pure virtual.
-  EXPECT_EQ("DW_VIRTUALITY_pure_virtual", VirtualityString(DW_VIRTUALITY_max));
+  EXPECT_EQ(StringRef("DW_VIRTUALITY_pure_virtual"),
+            VirtualityString(DW_VIRTUALITY_max));
 
   // Invalid numbers shouldn't be stringified.
   EXPECT_EQ(nullptr, VirtualityString(DW_VIRTUALITY_max + 1));