ASoC: mxs: Don't set unused struct snd_pcm_hardware fields
authorLars-Peter Clausen <lars@metafoo.de>
Mon, 6 Jan 2014 13:19:12 +0000 (14:19 +0100)
committerMark Brown <broonie@linaro.org>
Tue, 7 Jan 2014 11:41:32 +0000 (11:41 +0000)
The ASoC core assumes that the PCM component of the ASoC card transparently
moves data around and does not impose any restrictions on the memory layout or
the transfer speed. It ignores all fields from the snd_pcm_hardware struct for
the PCM driver that are related to this. Setting these fields in the PCM driver
might suggest otherwise though, so rather not set them.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Tested-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Mark Brown <broonie@linaro.org>
sound/soc/mxs/mxs-pcm.c

index 04a6b0d60944e1b13350dac3fd2fa708dd3c64d5..2e0863a70da33b4f168e55b4f3f2340b64b23435 100644 (file)
@@ -36,11 +36,6 @@ static const struct snd_pcm_hardware snd_mxs_hardware = {
                                  SNDRV_PCM_INFO_RESUME |
                                  SNDRV_PCM_INFO_INTERLEAVED |
                                  SNDRV_PCM_INFO_HALF_DUPLEX,
-       .formats                = SNDRV_PCM_FMTBIT_S16_LE |
-                                 SNDRV_PCM_FMTBIT_S20_3LE |
-                                 SNDRV_PCM_FMTBIT_S24_LE,
-       .channels_min           = 2,
-       .channels_max           = 2,
        .period_bytes_min       = 32,
        .period_bytes_max       = 8192,
        .periods_min            = 1,