[media] adv7180: Pass correct flags to request_threaded_irq()
authorLars-Peter Clausen <lars@metafoo.de>
Fri, 23 Jan 2015 15:52:21 +0000 (12:52 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Mon, 2 Feb 2015 13:15:53 +0000 (11:15 -0200)
Most IRQ controllers support different types of interrupts. The adv7180
generates falling edge interrupts, so make sure to pass IRQF_TRIGGER_FALLING
to request_threaded_irq() so the IRQ controller is configured for the
correct mode.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Federico Vaga <federico.vaga@gmail.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/i2c/adv7180.c

index 7666d10d3f16b4aa546cb7e264773075df08d864..15deaad1c6eb5d5d8010e8f2ece5fb6ed3ba1538 100644 (file)
@@ -630,7 +630,8 @@ static int adv7180_probe(struct i2c_client *client,
 
        if (state->irq) {
                ret = request_threaded_irq(client->irq, NULL, adv7180_irq,
-                                          IRQF_ONESHOT, KBUILD_MODNAME, state);
+                                          IRQF_ONESHOT | IRQF_TRIGGER_FALLING,
+                                          KBUILD_MODNAME, state);
                if (ret)
                        goto err_free_ctrl;
        }