projects
/
firefly-linux-kernel-4.4.55.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
24ab13e
)
ath10k: fix insufficient tracing buffer size
author
Michal Kazior
<michal.kazior@tieto.com>
Wed, 1 Apr 2015 19:53:19 +0000
(22:53 +0300)
committer
Kalle Valo
<kvalo@qca.qualcomm.com>
Thu, 9 Apr 2015 11:57:04 +0000
(14:57 +0300)
Some trace messages were truncated and a kernel
splat could be seen in the log:
WARNING: CPU: 3 PID: 0 at /devel/src/linux/drivers/net/wireless/ath/ath10k/./trace.h:114 ftrace_raw_event_ath10k_log_dbg+0x20e/0x220 [ath10k_core]()
Modules linked in: ath10k_pci(O) ath10k_core(O) ath iwldvm iwlwifi [last unloaded: iwlwifi]
CPU: 3 PID: 0 Comm: swapper/3 Tainted: G W O 4.0.0-rc3-wl-ath+ #703
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.7.5-20140531_083030-gandalf 04/01/2014
ffffffffa01d4cb0
ffff88001fd83998
ffffffff8191b86c
ffffffff81e3b718
0000000000000000
ffff88001fd839d8
ffffffff8105573a
ffff88001c0a5528
ffff88001bea9ae0
ffff88001c3dd940
00000000000d0018
ffff88001fd83a80
Call Trace:
<IRQ> [<
ffffffff8191b86c
>] dump_stack+0x45/0x57
[<
ffffffff8105573a
>] warn_slowpath_common+0x8a/0xc0
[<
ffffffff8105582a
>] warn_slowpath_null+0x1a/0x20
[<
ffffffffa01c61fe
>] ftrace_raw_event_ath10k_log_dbg+0x20e/0x220 [ath10k_core]
[<
ffffffffa01aaa6b
>] ath10k_dbg+0xbb/0xd0 [ath10k_core]
[<
ffffffff810eed89
>] ? trace_clock_local+0x9/0x10
[<
ffffffffa01bd069
>] ath10k_wmi_event_service_ready+0x479/0x520 [ath10k_core]
[<
ffffffff810fdf90
>] ? trace_buffer_unlock_commit+0x50/0x60
[<
ffffffffa01c2113
>] ath10k_wmi_tlv_op_rx+0x6b3/0x8b0 [ath10k_core]
This could be reproduced with:
trace-cmd record -e ath10k
ifconfig wlan0 down
ifconfig wlan0 up
Fixes: 5c01aa3de918 ("ath10k: deduplicate wmi service ready logic")
Fixes: ca996ec56608 ("ath10k: implement wmi-tlv backend")
Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
drivers/net/wireless/ath/ath10k/trace.h
patch
|
blob
|
history
diff --git
a/drivers/net/wireless/ath/ath10k/trace.h
b/drivers/net/wireless/ath/ath10k/trace.h
index 5407887380abe71a91a9570d3e23b063f67e59d3..71dfcd96354b809c8872fc0614a349a815fac13a 100644
(file)
--- a/
drivers/net/wireless/ath/ath10k/trace.h
+++ b/
drivers/net/wireless/ath/ath10k/trace.h
@@
-46,7
+46,7
@@
static inline void trace_ ## name(proto) {}
#undef TRACE_SYSTEM
#define TRACE_SYSTEM ath10k
-#define ATH10K_MSG_MAX
2
00
+#define ATH10K_MSG_MAX
4
00
DECLARE_EVENT_CLASS(ath10k_log_event,
TP_PROTO(struct ath10k *ar, struct va_format *vaf),