Add missing includes for msvc

Summary: MSVC is a stricter compiler and needs additional includes explicitly declared

Test Plan: fbmake runtests

Reviewed By: njormrod@fb.com

FB internal diff: D1277004

diff --git a/folly/FBString.h b/folly/FBString.h
index a768dec35c1a1f84b920d70b7a06adfea32c2c3f..ea0df00cca32a5b9c3e87218d1a053592d4401b1 100644 (file)
--- a/folly/FBString.h
+++ b/folly/FBString.h
@@ -61,6 +61,7 @@
 #include <atomic>
 #include <limits>
 #include <type_traits>
+#include <algorithm>
 
 // libc++ doesn't provide this header
 #ifndef _LIBCPP_VERSION

diff --git a/folly/Optional.h b/folly/Optional.h
index e877738db0a85323e881e52919f0ba2dc943d8bb..c155f10e1a4014d172748848ff674c6cefb4b724 100644 (file)
--- a/folly/Optional.h
+++ b/folly/Optional.h
@@ -61,6 +61,7 @@
 
 #include <boost/operators.hpp>
 
+#include "folly/Portability.h"
 
 namespace folly {
 

diff --git a/folly/String.cpp b/folly/String.cpp
index bf3fc38cde9fffb2167474f0a84a583d42c0a366..f50d1de8534dce74eeed5ea0ea2eb21524e813d4 100644 (file)
--- a/folly/String.cpp
+++ b/folly/String.cpp
@@ -22,6 +22,7 @@
 #include <cstring>
 #include <stdexcept>
 #include <iterator>
+#include <cctype>
 #include <glog/logging.h>
 
 namespace folly {

diff --git a/folly/Traits.h b/folly/Traits.h
index 966dcc578f7355e33cf8e8477c86f70dc67a3d24..9f90fa5678a022c4e8c4a11961d83b8e14fe6d45 100644 (file)
--- a/folly/Traits.h
+++ b/folly/Traits.h
@@ -22,6 +22,7 @@
 #include <memory>
 #include <limits>
 #include <type_traits>
+#include <functional>
 
 #include "folly/Portability.h"
 

diff --git a/folly/wangle/Future.h b/folly/wangle/Future.h
index 441d1f5a453235481751c9a91777b7641876f5e4..c1deb6add651c92bacf11796b9a1e275a25559ae 100644 (file)
--- a/folly/wangle/Future.h
+++ b/folly/wangle/Future.h
@@ -21,6 +21,7 @@
 #include <functional>
 #include <memory>
 #include <type_traits>
+#include <vector>
 
 #include "folly/MoveWrapper.h"
 #include "Promise.h"