iwlwifi: turn on a lockdep assertion
authorDan Carpenter <dan.carpenter@oracle.com>
Sun, 10 Jun 2012 11:25:22 +0000 (14:25 +0300)
committerJohannes Berg <johannes.berg@intel.com>
Wed, 13 Jun 2012 07:01:07 +0000 (09:01 +0200)
CMD_SYNC is zero so the if (cmd->flags & CMD_SYNC) is never true and we
never check the assertion.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/iwlwifi/dvm/lib.c

index cb1ca7a25dd5b4ec60e92f08d056d438732c5434..76f259283c3a30f857bfe34550f6897cd244895f 100644 (file)
@@ -1265,7 +1265,7 @@ int iwl_dvm_send_cmd(struct iwl_priv *priv, struct iwl_host_cmd *cmd)
         * the mutex, this ensures we don't try to send two
         * (or more) synchronous commands at a time.
         */
-       if (cmd->flags & CMD_SYNC)
+       if (!(cmd->flags & CMD_ASYNC))
                lockdep_assert_held(&priv->mutex);
 
        if (priv->ucode_owner == IWL_OWNERSHIP_TM &&