staging:sbe-2t3e3: remove assignment in if condition
authorHimangi Saraogi <himangi774@gmail.com>
Sat, 1 Mar 2014 21:38:46 +0000 (03:08 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 7 Mar 2014 21:29:25 +0000 (13:29 -0800)
This patch removes the assignment in an if condition to do away with
the checkpatch warning :'do not use assignment in if condition'.

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/sbe-2t3e3/dc.c

index f207b9e015cec162a10a5a63b72c0bc970e66de2..42ae67c5bc3352200c299b183d51c421c88c5539 100644 (file)
@@ -339,7 +339,8 @@ static int dc_init_descriptor_list(struct channel *sc)
                        SBE_2T3E3_RX_DESC_SECOND_ADDRESS_CHAINED | SBE_2T3E3_MTU;
 
                if (sc->ether.rx_data[i] == NULL) {
-                       if (!(m = dev_alloc_skb(MCLBYTES))) {
+                       m = dev_alloc_skb(MCLBYTES);
+                       if (!m) {
                                for (j = 0; j < i; j++) {
                                        dev_kfree_skb_any(sc->ether.rx_data[j]);
                                        sc->ether.rx_data[j] = NULL;