Type sizes and fields offsets inside structs are unsigned. This is a highly
authorDuncan Sands <baldrick@free.fr>
Thu, 15 Mar 2012 20:14:42 +0000 (20:14 +0000)
committerDuncan Sands <baldrick@free.fr>
Thu, 15 Mar 2012 20:14:42 +0000 (20:14 +0000)
theoretical fix since it only matters for types with >= 2^63 bits (!) and also
only matters if pointers have more than 64 bits, which is not supported anyway.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@152831 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Analysis/InstructionSimplify.cpp

index b095bc42726d14ce6902052a37d8c1f7bd545afd..f8d159dc43847a2a514182cb5b94638df4f0e3f8 100644 (file)
@@ -673,13 +673,11 @@ static bool accumulateGEPOffset(const TargetData &TD, GEPOperator *GEP,
     if (StructType *STy = dyn_cast<StructType>(*GTI)) {
       unsigned ElementIdx = OpC->getZExtValue();
       const StructLayout *SL = TD.getStructLayout(STy);
-      Offset += APInt(IntPtrWidth, SL->getElementOffset(ElementIdx),
-                      /*isSigned=*/true);
+      Offset += APInt(IntPtrWidth, SL->getElementOffset(ElementIdx));
       continue;
     }
 
-    APInt TypeSize(IntPtrWidth, TD.getTypeAllocSize(GTI.getIndexedType()),
-                   /*isSigned=*/true);
+    APInt TypeSize(IntPtrWidth, TD.getTypeAllocSize(GTI.getIndexedType()));
     Offset += OpC->getValue().sextOrTrunc(IntPtrWidth) * TypeSize;
   }
   return true;