mfd: ab8500-debugfs: Apply a check for -ENOMEM after allocating memory for sysfs
authorLee Jones <lee.jones@linaro.org>
Fri, 19 Jul 2013 07:44:50 +0000 (08:44 +0100)
committerLee Jones <lee.jones@linaro.org>
Mon, 2 Sep 2013 09:22:42 +0000 (10:22 +0100)
The AB8500 debugfs driver allocates memory for a new sysfs entry, but
fails to apply the proper post-allocation checks. If the device were to
run out of memory, the allocation would return NULL. Without the correct
checks the driver will continue to populate NULL->[show|store|...],
which would obviously cause a pointer dereference Oops.

Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/ab8500-debugfs.c

index a0afa64b471bbd87f7401297a2073ec0e753295d..fe8189c4385a12051bd338bd623beae6ff7af3ae 100644 (file)
@@ -2800,6 +2800,9 @@ static ssize_t ab8500_subscribe_write(struct file *file,
         */
        dev_attr[irq_index] = kmalloc(sizeof(struct device_attribute),
                GFP_KERNEL);
+       if (!dev_attr[irq_index])
+               return -ENOMEM;
+
        event_name[irq_index] = kmalloc(count, GFP_KERNEL);
        sprintf(event_name[irq_index], "%lu", user_val);
        dev_attr[irq_index]->show = show_irq;