video: fbdev-LCDC: Deletion of an unnecessary check before the function call "vfree"
authorMarkus Elfring <elfring@users.sourceforge.net>
Sat, 22 Nov 2014 15:51:31 +0000 (16:51 +0100)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Thu, 4 Dec 2014 14:16:01 +0000 (16:16 +0200)
The vfree() function performs also input parameter validation.
Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
drivers/video/fbdev/sh_mobile_lcdcfb.c

index 2bcc84ac18c762f7bc7f5acecdb34149192a1308..cfde21d81c15e3f76d5d73f7ad55105c6f4416fc 100644 (file)
@@ -2181,8 +2181,7 @@ sh_mobile_lcdc_channel_fb_cleanup(struct sh_mobile_lcdc_chan *ch)
        if (!info || !info->device)
                return;
 
-       if (ch->sglist)
-               vfree(ch->sglist);
+       vfree(ch->sglist);
 
        fb_dealloc_cmap(&info->cmap);
        framebuffer_release(info);