ext4: error handling fix in ext4_ext_convert_to_initialized()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 26 Oct 2011 07:42:36 +0000 (03:42 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Wed, 26 Oct 2011 07:42:36 +0000 (03:42 -0400)
When allocated is unsigned it breaks the error handling at the end
of the function when we call:
allocated = ext4_split_extent(...);
if (allocated < 0)
err = allocated;

I've made it a signed int instead of unsigned.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
fs/ext4/extents.c

index 8686eb756b38e825357846b740695831ff6e259f..02a4d80573a18438c0b1cd4f1376efdf49287a12 100644 (file)
@@ -2928,7 +2928,8 @@ static int ext4_ext_convert_to_initialized(handle_t *handle,
        struct ext4_extent zero_ex;
        struct ext4_extent *ex;
        ext4_lblk_t ee_block, eof_block;
-       unsigned int allocated, ee_len, depth;
+       unsigned int ee_len, depth;
+       int allocated;
        int err = 0;
        int split_flag = 0;