usb: gadget: f_mass_storage: change default value of the removable parameter
authorMichal Nazarewicz <mina86@mina86.com>
Sat, 26 May 2012 23:32:39 +0000 (16:32 -0700)
committerFelipe Balbi <balbi@ti.com>
Mon, 4 Jun 2012 15:11:35 +0000 (18:11 +0300)
This commit changes the default value of the removable module parameter
from ā€œyā€ to ā€œnā€.  This comes with line with file_storag's default and
seems to be a better default.

Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/gadget/f_mass_storage.c

index f67b453740bdb430e220d1c7dc7287444028e8a3..72116fa49ffb5ea7e33391895d0ee9588b38c810 100644 (file)
  *                             backing storage.
  *     ro=b[,b...]     Default false, boolean for read-only access.
  *     removable=b[,b...]
- *                     Default true, boolean for removable media.
+ *                     Default false, boolean for removable media.
  *     cdrom=b[,b...]  Default false, boolean for whether to emulate
  *                             a CD-ROM drive.
  *     nofua=b[,b...]  Default false, booleans for ignore FUA flag
@@ -3167,8 +3167,7 @@ fsg_config_from_params(struct fsg_config *cfg,
        for (i = 0, lun = cfg->luns; i < cfg->nluns; ++i, ++lun) {
                lun->ro = !!params->ro[i];
                lun->cdrom = !!params->cdrom[i];
-               lun->removable = /* Removable by default */
-                       params->removable_count <= i || params->removable[i];
+               lun->removable = !!params->removable[i];
                lun->filename =
                        params->file_count > i && params->file[i][0]
                        ? params->file[i]
@@ -3203,4 +3202,3 @@ fsg_common_from_params(struct fsg_common *common,
        fsg_config_from_params(&cfg, params);
        return fsg_common_init(common, cdev, &cfg);
 }
-