nfs_lookup_verify_inode() - nd is *always* non-NULL here
authorAl Viro <viro@zeniv.linux.org.uk>
Sun, 10 Jun 2012 19:33:51 +0000 (15:33 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Sat, 14 Jul 2012 12:34:02 +0000 (16:34 +0400)
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/nfs/dir.c

index 48485f1f0bda52d028f8c7ff154986f7463929e4..ad5aef4995aaeef84301156a9897bdfde468d500 100644 (file)
@@ -1069,19 +1069,16 @@ int nfs_lookup_verify_inode(struct inode *inode, struct nameidata *nd)
 
        if (IS_AUTOMOUNT(inode))
                return 0;
-       if (nd != NULL) {
-               /* VFS wants an on-the-wire revalidation */
-               if (nd->flags & LOOKUP_REVAL)
-                       goto out_force;
-               /* This is an open(2) */
-               if (nfs_lookup_check_intent(nd->flags, LOOKUP_OPEN) != 0 &&
-                               !(server->flags & NFS_MOUNT_NOCTO) &&
-                               (S_ISREG(inode->i_mode) ||
-                                S_ISDIR(inode->i_mode)))
-                       goto out_force;
-               return 0;
-       }
-       return nfs_revalidate_inode(server, inode);
+       /* VFS wants an on-the-wire revalidation */
+       if (nd->flags & LOOKUP_REVAL)
+               goto out_force;
+       /* This is an open(2) */
+       if (nfs_lookup_check_intent(nd->flags, LOOKUP_OPEN) != 0 &&
+                       !(server->flags & NFS_MOUNT_NOCTO) &&
+                       (S_ISREG(inode->i_mode) ||
+                        S_ISDIR(inode->i_mode)))
+               goto out_force;
+       return 0;
 out_force:
        return __nfs_revalidate_inode(server, inode);
 }