nfsd4: seq->status_flags may be used unitialized
authorBenny Halevy <bhalevy@tonian.com>
Thu, 20 Oct 2011 02:13:06 +0000 (19:13 -0700)
committerJ. Bruce Fields <bfields@redhat.com>
Mon, 24 Oct 2011 08:24:28 +0000 (04:24 -0400)
Reported-by: Gopala Suryanarayana <gsuryanarayana@vmware.com>
Signed-off-by: Benny Halevy <bhalevy@tonian.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
fs/nfsd/nfs4state.c

index b51ad43b7ea1ab2df49d2a8dc601bdc1e52d9f5f..1527aaffb0003a45dd365a10c29e2b946b25edb2 100644 (file)
@@ -1947,11 +1947,13 @@ out:
                atomic_inc(&clp->cl_refcount);
                switch (clp->cl_cb_state) {
                case NFSD4_CB_DOWN:
-                       seq->status_flags |= SEQ4_STATUS_CB_PATH_DOWN;
+                       seq->status_flags = SEQ4_STATUS_CB_PATH_DOWN;
                        break;
                case NFSD4_CB_FAULT:
-                       seq->status_flags |= SEQ4_STATUS_BACKCHANNEL_FAULT;
+                       seq->status_flags = SEQ4_STATUS_BACKCHANNEL_FAULT;
                        break;
+               default:
+                       seq->status_flags = 0;
                }
        }
        kfree(conn);