sctp: xmit sctp packet always return no route error
authorWei Yongjun <yjwei@cn.fujitsu.com>
Sun, 28 Jun 2009 22:49:37 +0000 (22:49 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 30 Jun 2009 02:41:53 +0000 (19:41 -0700)
Commit 'net: skb->dst accessors'(adf30907d63893e4208dfe3f5c88ae12bc2f25d5)
broken the sctp protocol stack, the sctp packet can never be sent out after
Eric Dumazet's patch, which have typo in the sctp code.

Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Acked-by: Vlad Yasevich <vladisalv.yasevich@hp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/output.c

index b764114445156dc69146856c118cbf1a725addca..b94c2119056661aaa61073a29bd429f069f7923f 100644 (file)
@@ -407,7 +407,7 @@ int sctp_packet_transmit(struct sctp_packet *packet)
        }
        dst = dst_clone(tp->dst);
        skb_dst_set(nskb, dst);
-       if (dst)
+       if (!dst)
                goto no_route;
 
        /* Build the SCTP header.  */