From: Chris Lattner Date: Sun, 7 Dec 2008 00:21:18 +0000 (+0000) Subject: remove the ability to get memdep info for vaarg. I don't think the X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;ds=sidebyside;h=84b9a56d11c119d2eadbc2ff4d56d33c25a07460;p=oota-llvm.git remove the ability to get memdep info for vaarg. I don't think the original impl was correct and noone actually makes the query anyway. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@60639 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Analysis/MemoryDependenceAnalysis.cpp b/lib/Analysis/MemoryDependenceAnalysis.cpp index 44119d7b6b7..24e45520c25 100644 --- a/lib/Analysis/MemoryDependenceAnalysis.cpp +++ b/lib/Analysis/MemoryDependenceAnalysis.cpp @@ -109,6 +109,10 @@ getCallSiteDependency(CallSite CS, BasicBlock::iterator ScanIt, BasicBlock *BB) MemDepResult MemoryDependenceAnalysis:: getDependencyFrom(Instruction *QueryInst, BasicBlock::iterator ScanIt, BasicBlock *BB) { + // The first instruction in a block is always non-local. + if (ScanIt == BB->begin()) + return MemDepResult::getNonLocal(); + // Get the pointer value for which dependence will be determined Value *MemPtr = 0; uint64_t MemSize = 0; @@ -122,17 +126,16 @@ getDependencyFrom(Instruction *QueryInst, BasicBlock::iterator ScanIt, MemPtr = LI->getPointerOperand(); MemSize = TD->getTypeStoreSize(LI->getType()); MemVolatile = LI->isVolatile(); - } else if (VAArgInst* V = dyn_cast(QueryInst)) { - MemPtr = V->getOperand(0); - MemSize = TD->getTypeStoreSize(V->getType()); } else if (FreeInst* F = dyn_cast(QueryInst)) { MemPtr = F->getPointerOperand(); // FreeInsts erase the entire structure, not just a field. MemSize = ~0UL; - } else { - assert((isa(QueryInst) || isa(QueryInst)) && - "Can only get dependency info for memory instructions!"); + } else if (isa(QueryInst) || isa(QueryInst)) { return getCallSiteDependency(CallSite::get(QueryInst), ScanIt, BB); + } else { + // Otherwise, this is a vaarg or non-memory instruction, just return a + // clobber dependency on the previous inst. + return MemDepResult::getClobber(--ScanIt); } // Walk backwards through the basic block, looking for dependencies