From: Chris Lattner Date: Wed, 14 Aug 2002 22:11:52 +0000 (+0000) Subject: Avoid creating 'load X, 0' instead of just 'load X' X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;ds=sidebyside;h=b9a7793ecba7824aaf48626ff6b116512e0b56c4;p=oota-llvm.git Avoid creating 'load X, 0' instead of just 'load X' This _trivial_ change causes GCSE and LICM to be much more effective at hoisting loads. Before it would not be able to eliminate 'load X' if there was just a dominating 'load X, 0' because the expressions were not identical. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@3337 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Transforms/ExprTypeConvert.cpp b/lib/Transforms/ExprTypeConvert.cpp index 98bc9425f45..ede89563717 100644 --- a/lib/Transforms/ExprTypeConvert.cpp +++ b/lib/Transforms/ExprTypeConvert.cpp @@ -990,6 +990,9 @@ static void ConvertOperandToType(User *U, Value *OldVal, Value *NewVal, } assert(LoadedTy->isFirstClassType()); + if (Indices.size() == 1) + Indices.clear(); // Do not generate load X, 0 + Res = new LoadInst(NewVal, Indices, Name); assert(Res->getType()->isFirstClassType() && "Load of structure or array!"); break;