From: Francesco Lavra <francescolavra@interfree.it>
Date: Thu, 31 Dec 2009 11:47:11 +0000 (-0300)
Subject: V4L/DVB (13961): em28xx-dvb: fix memleak in dvb_fini()
X-Git-Tag: firefly_0821_release~10186^2~2006
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=0192e1bfd9a979b014a59da0c32e50d4aa3f8f1d;p=firefly-linux-kernel-4.4.55.git
V4L/DVB (13961): em28xx-dvb: fix memleak in dvb_fini()
commit 19f48cb105b7fa18d0dcab435919a3a29b7a7c4c upstream.
this patch fixes a memory leak which occurs when an em28xx card with DVB
extension is unplugged or its DVB extension driver is unloaded. In
dvb_fini(), dev->dvb must be freed before being set to NULL, as is done
in dvb_init() in case of error.
Note that this bug is also present in the latest stable kernel release.
Signed-off-by: Francesco Lavra <francescolavra@interfree.it>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
diff --git a/drivers/media/video/em28xx/em28xx-dvb.c b/drivers/media/video/em28xx/em28xx-dvb.c
index db749461e5c6..efddf15d498c 100644
--- a/drivers/media/video/em28xx/em28xx-dvb.c
+++ b/drivers/media/video/em28xx/em28xx-dvb.c
@@ -610,6 +610,7 @@ static int dvb_fini(struct em28xx *dev)
if (dev->dvb) {
unregister_dvb(dev->dvb);
+ kfree(dev->dvb);
dev->dvb = NULL;
}