From: Al Viro Date: Fri, 13 Apr 2012 15:49:04 +0000 (-0400) Subject: btrfs: btrfs_root_readonly() broken on big-endian X-Git-Tag: firefly_0821_release~7541^2~1302 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=025a55c8acd5b796af80305a800b343bb51c8f0c;p=firefly-linux-kernel-4.4.55.git btrfs: btrfs_root_readonly() broken on big-endian commit 6ed3cf2cdfce4c9f1d73171bd3f27d9cb77b734e upstream. ->root_flags is __le64 and all accesses to it go through the helpers that do proper conversions. Except for btrfs_root_readonly(), which checks bit 0 as in host-endian... Signed-off-by: Al Viro Cc: Chris Mason Signed-off-by: Greg Kroah-Hartman --- diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h index 3b859a3e6a0e..66179bcb16f6 100644 --- a/fs/btrfs/ctree.h +++ b/fs/btrfs/ctree.h @@ -1972,7 +1972,7 @@ BTRFS_SETGET_STACK_FUNCS(root_last_snapshot, struct btrfs_root_item, static inline bool btrfs_root_readonly(struct btrfs_root *root) { - return root->root_item.flags & BTRFS_ROOT_SUBVOL_RDONLY; + return (root->root_item.flags & cpu_to_le64(BTRFS_ROOT_SUBVOL_RDONLY)) != 0; } /* struct btrfs_super_block */