From: Yasuaki Ishimatsu Date: Thu, 31 Jan 2013 03:23:53 +0000 (+0000) Subject: ACPI / dock: Fix acpi_bus_get_device() check in drivers/acpi/dock.c X-Git-Tag: firefly_0821_release~3680^2~1034^2~1^2~13 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=02df7349d29f99ede4c97504ab67e3082c95c15e;p=firefly-linux-kernel-4.4.55.git ACPI / dock: Fix acpi_bus_get_device() check in drivers/acpi/dock.c acpi_bus_get_device() returns int not acpi_status. The patch change not to apply ACPI_SUCCESS() to the return value of acpi_bus_get_device(). Signed-off-by: Yasuaki Ishimatsu Signed-off-by: Rafael J. Wysocki --- diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c index 78648f811049..68d720af71ed 100644 --- a/drivers/acpi/dock.c +++ b/drivers/acpi/dock.c @@ -825,7 +825,7 @@ static ssize_t show_docked(struct device *dev, struct dock_station *dock_station = dev->platform_data; - if (ACPI_SUCCESS(acpi_bus_get_device(dock_station->handle, &tmp))) + if (!acpi_bus_get_device(dock_station->handle, &tmp)) return snprintf(buf, PAGE_SIZE, "1\n"); return snprintf(buf, PAGE_SIZE, "0\n"); }