From: Joel Marcey Date: Fri, 27 Jun 2014 21:47:54 +0000 (-0700) Subject: Be explicit about what we're passing to Endian::big X-Git-Tag: v0.22.0~488 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=09a81a96ea2f9790242675f3c84013266c38d684;p=folly.git Be explicit about what we're passing to Endian::big Summary: This prevents a linker error on OSX: ``` Undefined symbols for architecture x86_64: "folly::detail::EndianIntBase::swap(unsigned long)", referenced from: __GLOBAL__sub_I_MacAddress.cpp in libfolly.a(MacAddress.cpp.o) ld: symbol(s) not found for architecture x86_64 ``` We need folly and third-party changes in order to land a pull request for HHVM that starts to get FastCGI running on OSX. See the checklist of the HHVM pull request here: https://github.com/facebook/hhvm/pull/2944#issuecomment-47281003 Closes #68 GitHub Author: Daniel Sloof @override-unit-failures Test Plan: fbmake runtests 100% Reviewed By: pt@fb.com, njormrod@fb.com FB internal diff: D1407426 --- diff --git a/folly/MacAddress.cpp b/folly/MacAddress.cpp index 6368483f..67934d77 100644 --- a/folly/MacAddress.cpp +++ b/folly/MacAddress.cpp @@ -24,7 +24,7 @@ using std::string; namespace folly { -const MacAddress MacAddress::BROADCAST{Endian::big(0xffffffffffffU)}; +const MacAddress MacAddress::BROADCAST{Endian::big(uint64_t(0xffffffffffffU))}; const MacAddress MacAddress::ZERO; MacAddress::MacAddress(StringPiece str) {