From: XinHong Zhu Date: Thu, 13 Feb 2014 03:59:38 +0000 (+0800) Subject: [SCSI] pm80xx: no need for tag allocation when issuing the command of unregistering... X-Git-Tag: firefly_0821_release~176^2~4190^2~45 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=09f942bd83610f60f3b00b8f942a79f402307fe6;p=firefly-linux-kernel-4.4.55.git [SCSI] pm80xx: no need for tag allocation when issuing the command of unregistering device In function pm8001_dev_gone_notify we consume a tag from bitmap resource and later don't free that tag resource, so the tag resource will never be freed. In the function we don't need to use any tag to issue command for unregistering the device . Signed-off-by: XinHong Zhu Acked-by: Lindar Liu Signed-off-by: James Bottomley --- diff --git a/drivers/scsi/pm8001/pm8001_sas.c b/drivers/scsi/pm8001/pm8001_sas.c index f50ac44b950e..ba3088c99bfa 100644 --- a/drivers/scsi/pm8001/pm8001_sas.c +++ b/drivers/scsi/pm8001/pm8001_sas.c @@ -865,13 +865,11 @@ ex_err: static void pm8001_dev_gone_notify(struct domain_device *dev) { unsigned long flags = 0; - u32 tag; struct pm8001_hba_info *pm8001_ha; struct pm8001_device *pm8001_dev = dev->lldd_dev; pm8001_ha = pm8001_find_ha_by_dev(dev); spin_lock_irqsave(&pm8001_ha->lock, flags); - pm8001_tag_alloc(pm8001_ha, &tag); if (pm8001_dev) { u32 device_id = pm8001_dev->device_id;