From: NAKAMURA Takumi <geek4civic@gmail.com>
Date: Sat, 5 Feb 2011 08:53:12 +0000 (+0000)
Subject: Windows/Program.inc: Quote arguments when dubious characters (used by cmd.exe or... 
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=0f0889e24b6521fafeea7d2ab17bd14897773e0c;p=oota-llvm.git

Windows/Program.inc: Quote arguments when dubious characters (used by cmd.exe or MSYS shell) are included to invoke CreateProcess(). Thanks to Danil Malyshev.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@124945 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Support/Windows/Program.inc b/lib/Support/Windows/Program.inc
index 0b92c78dc89..f83ba64a8dd 100644
--- a/lib/Support/Windows/Program.inc
+++ b/lib/Support/Windows/Program.inc
@@ -137,7 +137,7 @@ static HANDLE RedirectIO(const Path *path, int fd, std::string* ErrMsg) {
 /// ArgNeedsQuotes - Check whether argument needs to be quoted when calling
 /// CreateProcess.
 static bool ArgNeedsQuotes(const char *Str) {
-  return Str[0] == '\0' || strchr(Str, ' ') != 0;
+  return Str[0] == '\0' || strpbrk(Str, "\t \"&\'()*<>\\`^|") != 0;
 }