From: Greg Kroah-Hartman Date: Mon, 14 Oct 2013 17:18:55 +0000 (-0700) Subject: Revert "USB: OHCI: Properly handle ohci-at91 suspend" X-Git-Tag: firefly_0821_release~176^2~5061^2~51 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=118cb990cd66791e5ae86bfae22b8b9c64bd5fd9;p=firefly-linux-kernel-4.4.55.git Revert "USB: OHCI: Properly handle ohci-at91 suspend" This reverts commit 056ca85dab838bf064485b6cd73ddfcd9bf707e7. Manjunath is no longer at Linaro, the email address bounces. Given that, and the fact that others have reported problems with these patches, I'm reverting them until someone from Linaro who can SUPPORT THEM submits them. I will no longer accept patches from linaro.com developers unless a senior Linaro developer has signed off on them, which did not happen with this patch set. Reported-by: Olof Johansson Cc: Manjunath Goudar Cc: Manjunath Goudar Cc: Alan Stern Cc: Arnd Bergmann --- diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c index f2d840370a87..476b5a5baf25 100644 --- a/drivers/usb/host/ohci-at91.c +++ b/drivers/usb/host/ohci-at91.c @@ -636,14 +636,8 @@ ohci_hcd_at91_drv_suspend(struct platform_device *pdev, pm_message_t mesg) { struct usb_hcd *hcd = platform_get_drvdata(pdev); struct ohci_hcd *ohci = hcd_to_ohci(hcd); - bool do_wakeup = device_may_wakeup(&pdev->dev); - int ret; - ret = ohci_suspend(hcd, do_wakeup); - if (ret) - return ret; - - if (do_wakeup) + if (device_may_wakeup(&pdev->dev)) enable_irq_wake(hcd->irq); /* @@ -664,7 +658,7 @@ ohci_hcd_at91_drv_suspend(struct platform_device *pdev, pm_message_t mesg) at91_stop_clock(); } - return ret; + return 0; } static int ohci_hcd_at91_drv_resume(struct platform_device *pdev)