From: Linus Torvalds Date: Sat, 11 Apr 2015 20:46:07 +0000 (-0700) Subject: Revert "dmaengine: Add a warning for drivers not using the generic slave caps retrieval" X-Git-Tag: firefly_0821_release~176^2~2041 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=12522eeac88165d0db56a6a19ab607addf728995;p=firefly-linux-kernel-4.4.55.git Revert "dmaengine: Add a warning for drivers not using the generic slave caps retrieval" This reverts commit ecc19d17868be9c9f8f00ed928791533c420f3e0. It added a new warning to try to encourage driver writers to set the device capabities properly, but drivers haven't been updated and in the meantime it just generaters a scary message that users cannot actually do anything about. Warnings like these are appropriate if you actually expect to fix the code that causes them. They are not appropriate for releases. Requested-by: Peter Hurley Signed-off-by: Linus Torvalds --- diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c index f15712f2fec6..ac336a961dea 100644 --- a/drivers/dma/dmaengine.c +++ b/drivers/dma/dmaengine.c @@ -859,9 +859,6 @@ int dma_async_device_register(struct dma_device *device) BUG_ON(!device->device_issue_pending); BUG_ON(!device->dev); - WARN(dma_has_cap(DMA_SLAVE, device->cap_mask) && !device->directions, - "this driver doesn't support generic slave capabilities reporting\n"); - /* note: this only matters in the * CONFIG_ASYNC_TX_ENABLE_CHANNEL_SWITCH=n case */