From: Chris Lattner <sabre@nondot.org>
Date: Fri, 5 Aug 2005 01:02:04 +0000 (+0000)
Subject: Now that hasConstantValue is more careful w.r.t. returning values that only
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=1325b42a7dc38e99e1aa3531395d1678b31d3c55;p=oota-llvm.git

Now that hasConstantValue is more careful w.r.t. returning values that only
dominate the PHI node, this code can go away.  This also makes passes more
aggressive, e.g. implementing Transforms/CondProp/phisimplify2.ll


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@22670 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/VMCore/BasicBlock.cpp b/lib/VMCore/BasicBlock.cpp
index 407080cf68b..bdcfb365c6e 100644
--- a/lib/VMCore/BasicBlock.cpp
+++ b/lib/VMCore/BasicBlock.cpp
@@ -193,11 +193,10 @@ void BasicBlock::removePredecessor(BasicBlock *Pred,
       PN->removeIncomingValue(Pred, false);
       // If all incoming values to the Phi are the same, we can replace the Phi
       // with that value.
-      if (Value *PNV = PN->hasConstantValue())
-        if (!isa<Instruction>(PNV)) {
-          PN->replaceAllUsesWith(PNV);
-          PN->eraseFromParent();
-        }
+      if (Value *PNV = PN->hasConstantValue()) {
+        PN->replaceAllUsesWith(PNV);
+        PN->eraseFromParent();
+      }
     }
   }
 }