From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Date: Wed, 29 May 2013 05:47:09 +0000 (+0800)
Subject: serial: samsung: missing uart_unregister_driver() on error in s3c24xx_serial_modinit()
X-Git-Tag: firefly_0821_release~176^2~5846^2~28
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=147275983e42e07f4c9f3764a91ff65be026aea9;p=firefly-linux-kernel-4.4.55.git

serial: samsung: missing uart_unregister_driver() on error in s3c24xx_serial_modinit()

Add the missing uart_unregister_driver() before return from
s3c24xx_serial_modinit() in the error handling case.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
index 89429410a245..1c2b8c31fde1 100644
--- a/drivers/tty/serial/samsung.c
+++ b/drivers/tty/serial/samsung.c
@@ -1798,7 +1798,13 @@ static int __init s3c24xx_serial_modinit(void)
 		return ret;
 	}
 
-	return platform_driver_register(&samsung_serial_driver);
+	ret = platform_driver_register(&samsung_serial_driver);
+	if (ret < 0) {
+		pr_err("Failed to register platform driver\n");
+		uart_unregister_driver(&s3c24xx_uart_drv);
+	}
+
+	return ret;
 }
 
 static void __exit s3c24xx_serial_modexit(void)