From: Daeseok Youn Date: Sun, 9 Mar 2014 23:56:55 +0000 (+0900) Subject: staging: cxt1e1: remove redundant memset() call X-Git-Tag: firefly_0821_release~176^2~4193^2~203 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=14eec444302c97a692a9cdc556f7590355610f92;p=firefly-linux-kernel-4.4.55.git staging: cxt1e1: remove redundant memset() call The name array doens't need to set to 0. Because sprintf/snprintf adds a terminating '\0'. And also it doesn't need to assign name array address to np pointer. Signed-off-by: Daeseok Youn Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/cxt1e1/linux.c b/drivers/staging/cxt1e1/linux.c index b2a06cafa63e..58fe0fe5228a 100644 --- a/drivers/staging/cxt1e1/linux.c +++ b/drivers/staging/cxt1e1/linux.c @@ -214,15 +214,13 @@ status_t c4_wq_port_init(mpi_t *pi) { - char name[16], *np; /* NOTE: name of the queue limited by system + char name[16]; /* NOTE: name of the queue limited by system * to 10 characters */ - if (pi->wq_port) return 0; /* already initialized */ - np = name; - memset(name, 0, 16); - sprintf(np, "%s%d", pi->up->devname, pi->portnum); /* IE pmcc4-01) */ + /* IE pmcc4-01 */ + snprintf(name, sizeof(name), "%s%d", pi->up->devname, pi->portnum); #ifdef RLD_RESTART_DEBUG pr_info(">> %s: creating workqueue <%s> for Port %d.\n",