From: Ondrej Lehecka <lehecka@fb.com>
Date: Fri, 31 Jul 2015 00:33:21 +0000 (-0700)
Subject: Fix 'missing declarations' and 'unusued parameter' warnings
X-Git-Tag: v0.53.0~26
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=17e68d9864612a9169b23ca2dc8b35070390cb7c;p=folly.git

Fix 'missing declarations' and 'unusued parameter' warnings

Summary: enum iterators operator!= didn't use the iterator parameter for comparison
because they assumed you only ever compare to end. Change the operator!= to
look at the iterator parameter to check if it was end.

Thrift generated code for reflection initializers for some types that weren't
declared before definition because they were never called outside of the file.
Marked those initializers as 'static'.

Reviewed By: @alandau

Differential Revision: D2284371
---

diff --git a/folly/IPAddressException.h b/folly/IPAddressException.h
index 1ab86efa..164d5407 100644
--- a/folly/IPAddressException.h
+++ b/folly/IPAddressException.h
@@ -32,7 +32,7 @@ class IPAddressFormatException : public std::exception {
   explicit IPAddressFormatException(const std::string& msg)
       : msg_(msg) {}
   IPAddressFormatException(
-    const IPAddressFormatException& exception_) = default;
+    const IPAddressFormatException&) = default;
   template<typename... Args>
   explicit IPAddressFormatException(Args&&... args)
       : msg_(to<std::string>(std::forward<Args>(args)...)) {}
@@ -51,7 +51,7 @@ class InvalidAddressFamilyException : public IPAddressFormatException {
   explicit InvalidAddressFamilyException(const std::string& msg)
       : IPAddressFormatException(msg) {}
   InvalidAddressFamilyException(
-    const InvalidAddressFamilyException& ex) = default;
+    const InvalidAddressFamilyException&) = default;
   explicit InvalidAddressFamilyException(sa_family_t family)
       : IPAddressFormatException("Address family " +
                                  detail::familyNameStr(family) +