From: Mauro Carvalho Chehab Date: Sat, 27 Oct 2012 19:29:34 +0000 (-0300) Subject: [media] s2255drv: index is always positive X-Git-Tag: firefly_0821_release~3680^2~275^2~813 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=199ab8fed4dcbe86dad74b6ed8733ff4c500e6df;p=firefly-linux-kernel-4.4.55.git [media] s2255drv: index is always positive drivers/media/usb/s2255/s2255drv.c:1654:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/usb/s2255/s2255drv.c b/drivers/media/usb/s2255/s2255drv.c index 2191f6ddf9e7..8ebec0d7bf59 100644 --- a/drivers/media/usb/s2255/s2255drv.c +++ b/drivers/media/usb/s2255/s2255drv.c @@ -1651,7 +1651,7 @@ static int vidioc_enum_frameintervals(struct file *file, void *priv, int is_ntsc = 0; #define NUM_FRAME_ENUMS 4 int frm_dec[NUM_FRAME_ENUMS] = {1, 2, 3, 5}; - if (fe->index < 0 || fe->index >= NUM_FRAME_ENUMS) + if (fe->index >= NUM_FRAME_ENUMS) return -EINVAL; switch (fe->width) { case 640: