From: jjenista <jjenista>
Date: Wed, 3 Mar 2010 21:56:55 +0000 (+0000)
Subject: found a bug where an object of one reach graph could get into another reach graph... 
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=1bfa8d4b765e4ca7397644d6f4c34a7144e343c8;p=IRC.git

found a bug where an object of one reach graph could get into another reach graph, which breaks everything
---

diff --git a/Robust/src/Analysis/Disjoint/ReachGraph.java b/Robust/src/Analysis/Disjoint/ReachGraph.java
index 93fe7044..07832de4 100644
--- a/Robust/src/Analysis/Disjoint/ReachGraph.java
+++ b/Robust/src/Analysis/Disjoint/ReachGraph.java
@@ -161,6 +161,14 @@ public class ReachGraph {
     assert edge.getSrc() == referencer;
     assert edge.getDst() == referencee;
 
+    // edges are getting added twice to graphs now, the
+    // kind that should have abstract facts merged--use
+    // this check to prevent that
+    assert referencer.getReferenceTo( referencee,
+                                      edge.getType(),
+                                      edge.getField()
+                                      ) == null;
+
     referencer.addReferencee( edge );
     referencee.addReferencer( edge );
   }
@@ -869,6 +877,13 @@ public class ReachGraph {
   protected void transferOnto( HeapRegionNode hrnA, 
                                HeapRegionNode hrnB ) {
 
+    // don't allow a heap region from one graph to
+    // get transferred onto a region from another
+    // graph!!  Do the transfer on the equivalent
+    // elements!
+    assert id2hrn.get( hrnA.getID() ) == hrnA;
+    assert id2hrn.get( hrnB.getID() ) == hrnB;
+
     // clear references in and out of node b
     wipeOut( hrnB );
 
@@ -879,6 +894,7 @@ public class ReachGraph {
       HeapRegionNode hrnReferencee = edge.getDst();
       RefEdge        edgeNew       = edge.copy();
       edgeNew.setSrc( hrnB );
+      edgeNew.setDst( hrnB );
 
       addRefEdge( hrnB, hrnReferencee, edgeNew );
     }
@@ -889,6 +905,7 @@ public class ReachGraph {
       RefSrcNode onReferencer = edge.getSrc();
       RefEdge    edgeNew      = edge.copy();
       edgeNew.setDst( hrnB );
+      edgeNew.setDst( hrnB );
 
       addRefEdge( onReferencer, hrnB, edgeNew );
     }
@@ -1492,7 +1509,11 @@ public class ReachGraph {
                                    );                                        
       }
 
-      transferOnto( hrnCallee, hrnCaller );
+      // TODO: alpha should be some rewritten version of callee in caller context
+      hrnCaller.setAlpha( rsetEmpty );
+
+      // TODO: predicates should be exact same from caller version that satisfied
+      hrnCaller.setPreds( predsTrue );
     }
 
     // 3.b) callee -> callee edges
@@ -1527,12 +1548,13 @@ public class ReachGraph {
       HeapRegionNode hrnDstCaller = id2hrn.get( hrnDstCallee.getID() );
       assert hrnDstCaller != null;
       
+      // TODO: beta rewrites, preds from satisfier in caller
       RefEdge reCaller = new RefEdge( rsnCaller,
                                       hrnDstCaller,
                                       reCallee.getType(),
                                       reCallee.getField(),
-                                      reCallee.getBeta(),
-                                      reCallee.getPreds()
+                                      rsetEmpty,
+                                      predsTrue
                                       );
       addRefEdge( rsnCaller, hrnDstCaller, reCaller );	
     }