From: Owen Anderson <resistor@mac.com>
Date: Fri, 19 Jun 2009 18:34:09 +0000 (+0000)
Subject: Forgot to remove some explicit locking when it became implicit in the ValueMap.
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=1f0ba8c57bab92c2f2816f1a0c1ddd97559186f6;p=oota-llvm.git

Forgot to remove some explicit locking when it became implicit in the ValueMap.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@73778 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/VMCore/Constants.cpp b/lib/VMCore/Constants.cpp
index 5de1a08ac0b..56c900293dd 100644
--- a/lib/VMCore/Constants.cpp
+++ b/lib/VMCore/Constants.cpp
@@ -1473,6 +1473,7 @@ Constant *ConstantArray::get(const ArrayType *Ty,
 /// destroyConstant - Remove the constant from the constant table...
 ///
 void ConstantArray::destroyConstant() {
+  // Implicitly locked.
   ArrayConstants->remove(this);
   destroyConstantImpl();
 }
@@ -1601,6 +1602,7 @@ Constant *ConstantStruct::get(const std::vector<Constant*> &V, bool packed) {
 // destroyConstant - Remove the constant from the constant table...
 //
 void ConstantStruct::destroyConstant() {
+  // Implicitly locked.
   StructConstants->remove(this);
   destroyConstantImpl();
 }
@@ -1668,7 +1670,7 @@ Constant *ConstantVector::get(const std::vector<Constant*> &V) {
 // destroyConstant - Remove the constant from the constant table...
 //
 void ConstantVector::destroyConstant() {
-  sys::SmartScopedWriter<true> Write(&*ConstantsLock);
+  // Implicitly locked.
   VectorConstants->remove(this);
   destroyConstantImpl();
 }
@@ -1740,7 +1742,7 @@ ConstantPointerNull *ConstantPointerNull::get(const PointerType *Ty) {
 // destroyConstant - Remove the constant from the constant table...
 //
 void ConstantPointerNull::destroyConstant() {
-  sys::SmartScopedWriter<true> Writer(&*ConstantsLock);
+  // Implicitly locked.
   NullPtrConstants->remove(this);
   destroyConstantImpl();
 }
@@ -2721,7 +2723,7 @@ Constant *ConstantExpr::getZeroValueForNegationExpr(const Type *Ty) {
 // destroyConstant - Remove the constant from the constant table...
 //
 void ConstantExpr::destroyConstant() {
-  sys::SmartScopedWriter<true> Writer(&*ConstantsLock);
+  // Implicitly locked.
   ExprConstants->remove(this);
   destroyConstantImpl();
 }