From: Duncan Sands Date: Tue, 12 Aug 2008 09:43:15 +0000 (+0000) Subject: Point people to ConstantExpr and ConstantFolding, X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=20df07ba22c0b7e907c1a7912b5d3d1d2fb948db;p=oota-llvm.git Point people to ConstantExpr and ConstantFolding, in case they get the wrong idea. Fit in 80 columns. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@54676 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/include/llvm/Support/ConstantFolder.h b/include/llvm/Support/ConstantFolder.h index 8c36e8bb506..1d693eee1be 100644 --- a/include/llvm/Support/ConstantFolder.h +++ b/include/llvm/Support/ConstantFolder.h @@ -7,8 +7,10 @@ // //===----------------------------------------------------------------------===// // -// This file defines the ConstantFolder class, which provides a set of methods -// for creating constants, with minimal folding. +// This file defines the ConstantFolder class, a helper for IRBuilder. +// It provides IRBuilder with a set of methods for creating constants +// with minimal folding. For general constant creation and folding, +// use ConstantExpr and the routines in llvm/Analysis/ConstantFolding.h. // //===----------------------------------------------------------------------===// diff --git a/include/llvm/Support/TargetFolder.h b/include/llvm/Support/TargetFolder.h index a80fb6f71b2..fc0e9c4ffa7 100644 --- a/include/llvm/Support/TargetFolder.h +++ b/include/llvm/Support/TargetFolder.h @@ -7,9 +7,10 @@ // //===----------------------------------------------------------------------===// // -// This file defines the TargetFolder class, which provides a set of methods -// for creating constants, with target dependent folding. -// +// This file defines the TargetFolder class, a helper for IRBuilder. +// It provides IRBuilder with a set of methods for creating constants with +// target dependent folding. For general constant creation and folding, +// use ConstantExpr and the routines in llvm/Analysis/ConstantFolding.h. // //===----------------------------------------------------------------------===// @@ -153,7 +154,8 @@ public: // Compare Instructions //===--------------------------------------------------------------------===// - Constant *CreateCompare(CmpInst::Predicate P, Constant *LHS, Constant *RHS) const { + Constant *CreateCompare(CmpInst::Predicate P, Constant *LHS, + Constant *RHS) const { return Fold(ConstantExpr::getCompare(P, LHS, RHS)); } @@ -169,11 +171,13 @@ public: return Fold(ConstantExpr::getExtractElement(Vec, Idx)); } - Constant *CreateInsertElement(Constant *Vec, Constant *NewElt, Constant *Idx)const { + Constant *CreateInsertElement(Constant *Vec, Constant *NewElt, + Constant *Idx) const { return Fold(ConstantExpr::getInsertElement(Vec, NewElt, Idx)); } - Constant *CreateShuffleVector(Constant *V1, Constant *V2, Constant *Mask) const { + Constant *CreateShuffleVector(Constant *V1, Constant *V2, + Constant *Mask) const { return Fold(ConstantExpr::getShuffleVector(V1, V2, Mask)); }