From: Nicholas Ormrod Date: Thu, 25 Sep 2014 00:02:47 +0000 (-0700) Subject: Disable failing wangle test X-Git-Tag: v0.22.0~326 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=215076a5b55a59612346d1e07929f268c78e8227;p=folly.git Disable failing wangle test Summary: Under moderate load, this part of the test would fail. When there is resource contention, it is quite possible that the timeout will be exceeded. A further reduction of the time spread will render this test next to useless. Moderate load can be as little as running all of folly's tests at once, which is something that our testing infrastructure does quite frequently. fbconfig -r folly fbmake runtests Test Plan: fbconfig -r folly && fbmake runtests Reviewed By: hannesr@fb.com Subscribers: sdwilsh, fugalh, njormrod FB internal diff: D1576570 Tasks: 5225808 --- diff --git a/folly/wangle/test/FutureTest.cpp b/folly/wangle/test/FutureTest.cpp index 1bf27533..1f0fad3c 100644 --- a/folly/wangle/test/FutureTest.cpp +++ b/folly/wangle/test/FutureTest.cpp @@ -727,16 +727,6 @@ TEST(Future, waitWithSemaphoreForTime) { p2.setValue(true); EXPECT_TRUE(t.isReady()); } - { - Promise p; - Future f = p.getFuture(); - auto begin = std::chrono::system_clock::now(); - auto t = waitWithSemaphore(std::move(f), - std::chrono::milliseconds(1)); - auto end = std::chrono::system_clock::now(); - EXPECT_TRUE( end - begin < std::chrono::milliseconds(5)); - EXPECT_FALSE(t.isReady()); - } { auto t = waitWithSemaphore(makeFuture(), std::chrono::milliseconds(1));