From: Luck, Tony <tony.luck@intel.com>
Date: Wed, 16 Nov 2011 18:50:56 +0000 (-0800)
Subject: fix typo/thinko in get_random_bytes()
X-Git-Tag: firefly_0821_release~7541^2~824
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=21a465d5868b83e17a1c2434864fbb95b6414481;p=firefly-linux-kernel-4.4.55.git

fix typo/thinko in get_random_bytes()

commit bd29e568a4cb6465f6e5ec7c1c1f3ae7d99cbec1 upstream.

If there is an architecture-specific random number generator we use it
to acquire randomness one "long" at a time.  We should put these random
words into consecutive words in the result buffer - not just overwrite
the first word again and again.

Signed-off-by: Tony Luck <tony.luck@intel.com>
Acked-by: H. Peter Anvin <hpa@zytor.com>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/char/random.c b/drivers/char/random.c
index 154eeda26db5..8b47c2b57437 100644
--- a/drivers/char/random.c
+++ b/drivers/char/random.c
@@ -941,7 +941,7 @@ void get_random_bytes(void *buf, int nbytes)
 		if (!arch_get_random_long(&v))
 			break;
 
-		memcpy(buf, &v, chunk);
+		memcpy(p, &v, chunk);
 		p += chunk;
 		nbytes -= chunk;
 	}