From: Vasiliy Kulikov Date: Fri, 4 Feb 2011 12:23:56 +0000 (+0300) Subject: platform: x86: acer-wmi: world-writable sysfs threeg file X-Git-Tag: firefly_0821_release~10186^2~408 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=21f36372097491d31bb4a375f9a1c81be4ed8a87;p=firefly-linux-kernel-4.4.55.git platform: x86: acer-wmi: world-writable sysfs threeg file commit b80b168f918bba4b847e884492415546b340e19d upstream. Don't allow everybody to write to hardware registers. Signed-off-by: Vasiliy Kulikov Signed-off-by: Matthew Garrett Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c index 2222710bdf95..52183c4cc7ee 100644 --- a/drivers/platform/x86/acer-wmi.c +++ b/drivers/platform/x86/acer-wmi.c @@ -1065,7 +1065,7 @@ static ssize_t set_bool_threeg(struct device *dev, return -EINVAL; return count; } -static DEVICE_ATTR(threeg, S_IWUGO | S_IRUGO | S_IWUSR, show_bool_threeg, +static DEVICE_ATTR(threeg, S_IRUGO | S_IWUSR, show_bool_threeg, set_bool_threeg); static ssize_t show_interface(struct device *dev, struct device_attribute *attr,