From: Andrei Alexandrescu Date: Tue, 9 Jul 2013 23:11:19 +0000 (-0700) Subject: Fix build breakage in hphp X-Git-Tag: v0.22.0~929 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=2302d45ad8d8ddff953711d209139e10b5c40881;p=folly.git Fix build breakage in hphp Summary: This should fix the build breakage in hphp caused by the latest fbstring changes (after being ported to engshare). Note that I'm flying blind here; I couldn't test with the hphp build because I don't have write access to engshare. @agallagher could you please make sure that this works after the fix? fbconfig -r hphp && fbmake dbg Test Plan: tested on folly Reviewed By: tudorb@fb.com FB internal diff: D880140 --- diff --git a/folly/test/FBStringTest.cpp b/folly/test/FBStringTest.cpp index 65fb7ad1..ede69e6a 100644 --- a/folly/test/FBStringTest.cpp +++ b/folly/test/FBStringTest.cpp @@ -447,6 +447,12 @@ template void clause11_21_4_6_4(String & test) { pos = random(0, test.size()); // Uncomment below to see a bug in gcc /*res = */test.insert(test.begin() + pos, il); + + // Test with actual input iterators + stringstream ss; + ss << "hello cruel world"; + auto i = istream_iterator(ss); + test.insert(test.begin(), i, istream_iterator()); } template void clause11_21_4_6_5(String & test) {