From: Andrzej Hajda Date: Thu, 24 Sep 2015 14:00:20 +0000 (+0200) Subject: extcon: rt8973a: fix handling regmap_irq_get_virq result X-Git-Tag: firefly_0821_release~176^2~800^2~57^2~10 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=238ffc2e64646951d2d3c541f3624b01be5f65e4;p=firefly-linux-kernel-4.4.55.git extcon: rt8973a: fix handling regmap_irq_get_virq result The function can return negative value. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 Signed-off-by: Andrzej Hajda Signed-off-by: Chanwoo Choi --- diff --git a/drivers/extcon/extcon-rt8973a.c b/drivers/extcon/extcon-rt8973a.c index 3428b6aae1a2..1bc3737ea01c 100644 --- a/drivers/extcon/extcon-rt8973a.c +++ b/drivers/extcon/extcon-rt8973a.c @@ -594,7 +594,7 @@ static int rt8973a_muic_i2c_probe(struct i2c_client *i2c, for (i = 0; i < info->num_muic_irqs; i++) { struct muic_irq *muic_irq = &info->muic_irqs[i]; - unsigned int virq = 0; + int virq = 0; virq = regmap_irq_get_virq(info->irq_data, muic_irq->irq); if (virq <= 0)