From: Alexander Gordeev Date: Wed, 11 Feb 2015 14:42:37 +0000 (+0100) Subject: rcu: Remove unnecessary condition check in rcu_qsctr_help() X-Git-Tag: firefly_0821_release~176^2~1991^2~2^2^7~1 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=27153acbe1141ceecf098ca5d24c2ae2714c1a5f;p=firefly-linux-kernel-4.4.55.git rcu: Remove unnecessary condition check in rcu_qsctr_help() When the ->curtail and ->donetail pointers differ, ->rcucblist always points to the beginning of the current list and thus cannot be NULL. Therefore, the check ->rcucblist != NULL is redundant and this commit removes it. Cc: "Paul E. McKenney" Signed-off-by: Alexander Gordeev Signed-off-by: Paul E. McKenney --- diff --git a/kernel/rcu/tiny.c b/kernel/rcu/tiny.c index cc9ceca7bde1..d4e7fe5f3baf 100644 --- a/kernel/rcu/tiny.c +++ b/kernel/rcu/tiny.c @@ -103,8 +103,7 @@ EXPORT_SYMBOL(__rcu_is_watching); static int rcu_qsctr_help(struct rcu_ctrlblk *rcp) { RCU_TRACE(reset_cpu_stall_ticks(rcp)); - if (rcp->rcucblist != NULL && - rcp->donetail != rcp->curtail) { + if (rcp->donetail != rcp->curtail) { rcp->donetail = rcp->curtail; return 1; }