From: Christopher Dykes <cdykes@fb.com>
Date: Thu, 11 Aug 2016 21:17:31 +0000 (-0700)
Subject: Use explicitly sized integers in the Conv test
X-Git-Tag: v2016.08.15.00~11
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=27f1f7e81d920600c47df0d85b5ab6a2d6c6fc16;p=folly.git

Use explicitly sized integers in the Conv test

Summary: Because the tests are explicitly dependent on the size of these types, and `long` is a different size on Windows.

Reviewed By: yfeldblum

Differential Revision: D3704488

fbshipit-source-id: e15e95242c5e9c84165a50cfd2c3bc6e0d2e0c49
---

diff --git a/folly/test/ConvTest.cpp b/folly/test/ConvTest.cpp
index 42612818..0ac0ed5a 100644
--- a/folly/test/ConvTest.cpp
+++ b/folly/test/ConvTest.cpp
@@ -226,8 +226,8 @@ void test128Bit2String() {
 #endif
 
 TEST(Conv, Integral2String) {
-  testIntegral2String<std::string, char, short, int, long>();
-  testIntegral2String<fbstring, char, short, int, long>();
+  testIntegral2String<std::string, int8_t, int16_t, int32_t, int64_t>();
+  testIntegral2String<fbstring, int8_t, int16_t, int32_t, int64_t>();
 
 #if FOLLY_HAVE_INT128_T
   test128Bit2String<std::string>();
@@ -423,9 +423,9 @@ void testString2Integral() {
 }
 
 TEST(Conv, String2Integral) {
-  testString2Integral<const char*, signed char, short, int, long, long long>();
-  testString2Integral<std::string, signed char, short, int, long, long long>();
-  testString2Integral<fbstring, signed char, short, int, long, long long>();
+  testString2Integral<const char*, int8_t, int16_t, int32_t, int64_t>();
+  testString2Integral<std::string, int8_t, int16_t, int32_t, int64_t>();
+  testString2Integral<fbstring, int8_t, int16_t, int32_t, int64_t>();
 
   // Testing the behavior of the StringPiece* API
   // StringPiece* normally parses as much valid data as it can,