From: Julia Lawall <julia@diku.dk>
Date: Mon, 18 Jan 2010 08:29:19 +0000 (-0800)
Subject: drivers/net: Eliminate useless code
X-Git-Tag: firefly_0821_release~9833^2~3055^2~559
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=2ae3111eafd797e24cc390bb5ce6a8fa0deacdb2;p=firefly-linux-kernel-4.4.55.git

drivers/net: Eliminate useless code

The variable qdev is initialized twice to the same (side effect-free)
expression.  Drop one initialization.

A simplified version of the semantic match that finds this problem is:
(http://coccinelle.lip6.fr/)

// <smpl>
@forall@
idexpression *x;
identifier f!=ERR_PTR;
@@

x = f(...)
... when != x
(
x = f(...,<+...x...+>,...)
|
* x = f(...)
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c
index f922294fd349..4ef0afbcbe1b 100644
--- a/drivers/net/qla3xxx.c
+++ b/drivers/net/qla3xxx.c
@@ -4087,7 +4087,6 @@ static void __devexit ql3xxx_remove(struct pci_dev *pdev)
 	struct ql3_adapter *qdev = netdev_priv(ndev);
 
 	unregister_netdev(ndev);
-	qdev = netdev_priv(ndev);
 
 	ql_disable_interrupts(qdev);