From: Maxime Ripard Date: Sat, 10 May 2014 03:33:36 +0000 (-0500) Subject: clk: sunxi: Remove calls to clk_put X-Git-Tag: firefly_0821_release~176^2~3740^2^2~7 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=2c6fba1038f2b27fffe7ab0ddd42f9f283128105;p=firefly-linux-kernel-4.4.55.git clk: sunxi: Remove calls to clk_put Callers of clk_put must disable the clock first. This also means that as long as the clock is enabled the driver should hold a reference to that clock. Hence, the call to clk_put here are bogus and should be removed. Signed-off-by: Maxime Ripard Acked-by: Mike Turquette Signed-off-by: Emilio López --- diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c index bf5075e4b20f..9bfa21ac04f4 100644 --- a/drivers/clk/sunxi/clk-sunxi.c +++ b/drivers/clk/sunxi/clk-sunxi.c @@ -1339,17 +1339,13 @@ static void __init sunxi_clock_protect(void) /* memory bus clock - sun5i+ */ clk = clk_get(NULL, "mbus"); - if (!IS_ERR(clk)) { + if (!IS_ERR(clk)) clk_prepare_enable(clk); - clk_put(clk); - } /* DDR clock - sun4i+ */ clk = clk_get(NULL, "pll5_ddr"); - if (!IS_ERR(clk)) { + if (!IS_ERR(clk)) clk_prepare_enable(clk); - clk_put(clk); - } } static void __init sunxi_init_clocks(struct device_node *np)