From: Eric Paris Date: Tue, 30 Apr 2013 14:43:10 +0000 (-0400) Subject: audit: do not needlessly take a spinlock in copy_signal X-Git-Tag: firefly_0821_release~3680^2~487^2~7 X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=2ce88dd04276839002a3b31161090d282316610b;p=firefly-linux-kernel-4.4.55.git audit: do not needlessly take a spinlock in copy_signal current->signal->audit_* can only change from a netlink message from current. Obviously in this case we cannot be handling a netlink message from current. So there is no change these can change under us. No need to take a lock to read them. Signed-off-by: Eric Paris --- diff --git a/drivers/tty/tty_audit.c b/drivers/tty/tty_audit.c index 5f3868202183..a03a75163f02 100644 --- a/drivers/tty/tty_audit.c +++ b/drivers/tty/tty_audit.c @@ -134,12 +134,8 @@ void tty_audit_exit(void) */ void tty_audit_fork(struct signal_struct *sig) { - unsigned long flags; - - spin_lock_irqsave(¤t->sighand->siglock, flags); sig->audit_tty = current->signal->audit_tty; sig->audit_tty_log_passwd = current->signal->audit_tty_log_passwd; - spin_unlock_irqrestore(¤t->sighand->siglock, flags); } /**