From: Cong Hou Date: Mon, 26 Oct 2015 18:00:17 +0000 (+0000) Subject: Check the case that the numerator and denominator are both zeros when getting edge... X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=2d382f246b34e9ca6228cf4aedd314570e1f1246;p=oota-llvm.git Check the case that the numerator and denominator are both zeros when getting edge probabilities in BPI and return 100% in this case. This issue is triggered in PGO mode when bootstrapping LLVM. It seems that it is not guaranteed that edge weights are always greater than zero which are read from profile data. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@251317 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Analysis/BranchProbabilityInfo.cpp b/lib/Analysis/BranchProbabilityInfo.cpp index 9ab357b62cf..f4839469869 100644 --- a/lib/Analysis/BranchProbabilityInfo.cpp +++ b/lib/Analysis/BranchProbabilityInfo.cpp @@ -623,6 +623,11 @@ getEdgeProbability(const BasicBlock *Src, unsigned IndexInSuccessors) const { uint32_t N = getEdgeWeight(Src, IndexInSuccessors); uint32_t D = getSumForBlock(Src); + // It is possible that the edge weight on the only successor edge of Src is + // zero, in which case we return 100%. + if (N == 0 && D == 0) + return BranchProbability::getOne(); + return BranchProbability(N, D); } @@ -634,6 +639,11 @@ getEdgeProbability(const BasicBlock *Src, const BasicBlock *Dst) const { uint32_t N = getEdgeWeight(Src, Dst); uint32_t D = getSumForBlock(Src); + // It is possible that the edge weight on the only successor edge of Src is + // zero, in which case we return 100%. + if (N == 0 && D == 0) + return BranchProbability::getOne(); + return BranchProbability(N, D); }