From: Chris Lattner Date: Sun, 5 Oct 2008 00:50:57 +0000 (+0000) Subject: fix a bug where the bswap matcher could match a case involving X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=2f63ca3fa8ea22d34a35204517803b2b0bd0bd89;p=oota-llvm.git fix a bug where the bswap matcher could match a case involving ashr. It should only apply to lshr. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@57089 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Transforms/Scalar/InstructionCombining.cpp b/lib/Transforms/Scalar/InstructionCombining.cpp index 4f489718f6f..95ed49d5262 100644 --- a/lib/Transforms/Scalar/InstructionCombining.cpp +++ b/lib/Transforms/Scalar/InstructionCombining.cpp @@ -3912,9 +3912,12 @@ static bool CollectBSwapParts(Value *V, SmallVector &ByteValues) { if (I->getOpcode() == Instruction::Shl) { // X << 24 defines the top byte with the lowest of the input bytes. DestNo = ByteValues.size()-1; - } else { + } else if (I->getOpcode() == Instruction::LShr) { // X >>u 24 defines the low byte with the highest of the input bytes. DestNo = 0; + } else { + // Arithmetic shift right may have the top bits set. + return true; } // If the destination byte value is already defined, the values are or'd