From: Takashi Iwai <tiwai@suse.de>
Date: Mon, 27 Apr 2015 14:39:19 +0000 (+0200)
Subject: ALSA: hda - Fix missing va_end() call in snd_hda_codec_pcm_new()
X-Git-Tag: firefly_0821_release~176^2~1082^2~190
X-Git-Url: http://demsky.eecs.uci.edu/git/?a=commitdiff_plain;h=30e5f003ff4b2be86f71733b6c9b11355d66584c;p=firefly-linux-kernel-4.4.55.git

ALSA: hda - Fix missing va_end() call in snd_hda_codec_pcm_new()

Reported by coverity CID 1296024.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
index 27333e0d8ebe..b49feff0a319 100644
--- a/sound/pci/hda/hda_codec.c
+++ b/sound/pci/hda/hda_codec.c
@@ -873,14 +873,15 @@ struct hda_pcm *snd_hda_codec_pcm_new(struct hda_codec *codec,
 	struct hda_pcm *pcm;
 	va_list args;
 
-	va_start(args, fmt);
 	pcm = kzalloc(sizeof(*pcm), GFP_KERNEL);
 	if (!pcm)
 		return NULL;
 
 	pcm->codec = codec;
 	kref_init(&pcm->kref);
+	va_start(args, fmt);
 	pcm->name = kvasprintf(GFP_KERNEL, fmt, args);
+	va_end(args);
 	if (!pcm->name) {
 		kfree(pcm);
 		return NULL;